Skip to content

chore: update pre-commit hook sp-repo-review #836

Open
DimitriPapadopoulos wants to merge 3 commits into
zarr-developers:mainfrom
DimitriPapadopoulos:sp-repo-review
Open

chore: update pre-commit hook sp-repo-review #836
DimitriPapadopoulos wants to merge 3 commits into
zarr-developers:mainfrom
DimitriPapadopoulos:sp-repo-review

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Apr 12, 2026 •
edited
Loading

updates:

  • github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04

https://learn.scientific-python.org/development/guides/gha-wheels/#publishing

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos changed the title Sp repo review chore: update pre-commit hook sp-repo-review Apr 12, 2026
@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

DimitriPapadopoulos commented Apr 12, 2026

I am not sure how to test the changes for the GH105 rule.

@d-v-b
Copy link
Copy Markdown
Contributor

d-v-b commented Apr 12, 2026

we definitely do not want to merge any changes to our publishing workflow without tests in place. For example, a workflow that pushes to testpypi. I do not have access to testpypi for the zarr-developers organization -- it was claimed by @jakirkham, and he does not respond to any communication attempts. I opened a ticket to deal but so far no response from the pypi admins.

Short-term we should probably make a zarr-developers-test-pypi org on testpypi and use it while we wait for @jakirkham or the pypi admins to fix this.

@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Apr 20, 2026

Have followed up here: zarr-developers/zarr-python#3798 (comment)

Let's continue discussion in that issue

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor Author

DimitriPapadopoulos commented May 14, 2026

Rebased and temporarily ignoring GH105.

The CI errors seem unrelated.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (fa92ee7) to head (c2e315a).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #836   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          901       901           
=========================================
  Hits           901       901
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos
chore: update pre-commit hook sp-repo-review
06c0c4b 
updates:
- github.com/scientific-python/cookie: 2025.05.02 → 2026.04.04

enables a couple ingonred rules:
- PY005: Has tests folder
- PY006: Has pre-commit config
- RF103: pyupgrade must be selected
@DimitriPapadopoulos
Apply cookie rule PP304
88bc655 
  PyProject:
  └── PP304 Sets the log level in pytest ❌
      log_level should be set. This will allow logs to be displayed on failures.
@DimitriPapadopoulos
Temporarily ignore cookie rule GH105
c2e315a 
  GitHub Actions:
  └── GH105 Use Trusted Publishing instead of token-based publishing on PyPI ❌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitriPapadopoulos @d-v-b @jakirkham